Move string view decision to configure time - WIP#1608
Closed
SwintonStreet wants to merge 2 commits intoopen-source-parsers:masterfrom
Closed
Move string view decision to configure time - WIP#1608SwintonStreet wants to merge 2 commits intoopen-source-parsers:masterfrom
SwintonStreet wants to merge 2 commits intoopen-source-parsers:masterfrom
Conversation
Detected with clang-tidy.
This ensures that cmake between the compiled objects and the headers match. Previously, if they didn't match you could get linker issues.
Contributor
|
Attempting to address this is #1661 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP - look at moving the
JSONCPP_HAS_STRING_VIEWto configure time from compile time. This is so that there cannot be a mismatch between the compiled library objects and the headers.Another option is to move the definition to the header so this is always correct.
Only cmake builds are covered at the moment